Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid racing in closing Etcd.errc channel #19206

Closed
wants to merge 1 commit into from
Closed

Avoid racing in closing Etcd.errc channel #19206

wants to merge 1 commit into from
+38 −5

Conversation

joshuazh-x
Copy link
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Another fix for #19172. It may be an overkill as the odds for having writes to errc after stopc is closed is pretty low.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshuazh-x
Once this PR has been reviewed and has the lgtm label, please assign wenjiaswe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @joshuazh-x. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joshuazh-x joshuazh-x mentioned this pull request Jan 16, 2025
Open
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (76d836f) to head (e02c8dc).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
server/embed/etcd.go 53.84% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/etcd.go 75.25% <53.84%> (-0.61%) ⬇️

... and 31 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19206      +/-   ##
==========================================
- Coverage   68.83%   68.73%   -0.11%     
==========================================
  Files         420      420              
  Lines       35627    35639      +12     
==========================================
- Hits        24523    24495      -28     
- Misses       9683     9716      +33     
- Partials     1421     1428       +7

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d836f...e02c8dc. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

It's too complicated.

@ahrtr ahrtr closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress needs-ok-to-test size/M
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuazh-x @k8s-ci-robot @ahrtr